[ML] Update data-test-subj attributes for action buttons and add ml namespace#47032
Merged
pheyos merged 2 commits intoelastic:masterfrom Oct 2, 2019
Merged
[ML] Update data-test-subj attributes for action buttons and add ml namespace#47032pheyos merged 2 commits intoelastic:masterfrom
pheyos merged 2 commits intoelastic:masterfrom
Conversation
pheyos
added
:ml
test_ui_functional
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💚 Build Succeeded |
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Oct 2, 2019
…amespace (elastic#47032) This PR updates a couple ML data-test-subj attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates a couple ML data-test-subj attributes.
Details
data-test-subjattributes to table action menu entries, so we no longer have to rely on the button text.data-test-subjattributes in ML are now all prefixed with themlnamespace (and some of them have a bit more context in their name now).